XHTML 1.0 Transitional. Click to learn more about our commitment to accessibility and standards.
Skip navigation

News: Funny little code optimisation

Added 08 August 2009, 8:53 PM
I'm in the middle of reviewing a developers code. This amused me…

Code

      var url='';
      if(document.getElementById('file'+number))
      {
         url=document.getElementById('file'+number).value;
      }
      else
      {
         if (filename!='')
         {
            url=filename;
         }
      }

because it is exactly equivalent in behaviour to…

Code

      var url=filename;
      if(document.getElementById('file'+number))
      {
         url=document.getElementById('file'+number).value;
      }

I saw this straight away, and then I thought "hey, that's actually quite a complex optimisation". Are any programmers reading? I'd be interested if this is the kind of thing other people notice, or am I just fussier about things?

View all

Trackbacks

There have been no trackbacks yet


Comments

Ain't quite optimized yet.

Avatar
Optimization would be when you can avoid the second evaluation of "document.getElementById('file'+number)":

      var url=filename;
      var obj=document.getElementById('file'+number);
      if(obj)
      {
         url=obj.value;
      }

Avatar
Very true :).


Make comment
Your name: (join or login)
Post title:
Your message:

Edited 07 September 2010