HTML Logo by World Wide Web Consortium (www.w3.org). Click to learn more about our commitment to accessibility and standards.

Moving forward with Composr

ocPortal has been relaunched as Composr CMS. ocPortal 9 is superseded by Composr 10.

Head over to compo.sr for our new site, and to our migration roadmap. Existing ocPortal member accounts have been mirrored.


Points Challenge

Login / Search

 [ Join | More ]
 Add topic 
Posted
Rating:
#72406 (In Topic #15185)
Avatar

Community saint

The challenge refered to in Making an addon part 1

Ok so not really knowing the ocPortal code or its functions, objects etc properly yet I will make a feeble attempt at this challenge from what I can see as possible error spots:

While I see there is an evaluate method for the object defined I do not know if this evaluate method is meant to parse the set strings inside the object but if not then one issue would like be the use of single quote around line 5:


it should be double quoted in order for $data to be parsed like so

Code

$output.="<p>Some data: $data</p>";

othersie it could be written like so:

Code

$output.='<p>Some data: '.$data.'</p>';

Dunno if that is what you are looking for but that is one thing that stood out to me first?
Back to the top
 
Posted
Rating:
#72409
Avatar

You win ;).

I wrote that so long ago, and nobody bothered contesting, I completely forgot about the challenge.

The string concatenation/quote thing was an unintentional bug, but you alluded correctly to the real problem (running evaluate on a string, rather than a Tempcode object).


Become a fan of Composr on Facebook or add me as a friend. Add me on on Twitter. Support me on Patreon
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about Composr whenever you see the opportunity or support me on Patreon.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying Composr on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
1 guests and 0 members have just viewed this: None
Control functions:

Quick reply   Contract

Your name:
Your message: