HTML Logo by World Wide Web Consortium (www.w3.org). Click to learn more about our commitment to accessibility and standards.
Proud to be a PHP Open Source CMS
Learn more

> Home » Forum home » Deploying » View topic

v7.0.1 - Strange bug with animated gif avatars

Login / Search

 [ Join | More ]
 [More]
 Add topic 
Posted
Rating:
#87157 (In Topic #17779)
temp1024
Avatar

Community saint
Ok, Here is a strange one O_o.

On my site I'm using 75x75 avatars and one of my members chose this:

This avatar is actually 175x75 yet ocportal accepted it. Windows sees this as 49x66, and I suspect that ocportal thinks the same, which I assume is the size of the first frame and not that of the largest frame.

I don't particularity mind it as it looks good when shown in forum posts, but its inconsistent everywhere else. On the member profile page it appears in a lopsided border, and if it was in a blog post it would appear off-centre and the fireball gets cut off by the avatar box.

Of course if anything bigger slips-through then it could end up looking really ugly.

I'm guessing this is still happening in later versions.



Last edit: by temp1024
Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#87171
Chris Graham
Avatar

ocStaff (admin)
Strange one that. I agree with what you're saying, however the PHP GD library that we use doesn't support animated gifs, so it'll just see it as a single frame. You could try reporting this issue to the GD people and see if they'll make it smarter, but to resolve we'd have to implement our own gif file parser in ocPortal, which is prohibitive.


Become a fan of ocPortal on Facebook or add me as a friend.

Expand: Was I helpful? Was I helpful?

Expand: Follow me on Twitter Follow me on Twitter







If I answered something that you think should be in the documentation, please take the initiative and add it to the community documentation. We really need people to help out here and build a well-organised large support resource.
Back to the top
 
Posted
Item has a rating of 5 (Liked by Chris GrahamLiked by FletchLiked by BobSLiked by Jean)  
Rating:
#87177
temp1024
Avatar

Community saint
Or, option 3 would be to change:

Code

         $sx=imagesx($source);
         $sy=imagesy($source);
to:

Code

         if(get_file_extension($avatar_url)=='gif')
         {
            $header = unpack ('@6/'.'vwidth/'.'vheight', $from_file);
            $sx=$header['width'];
            $sy=$header['height'];
         } else
         {
            $sx=imagesx($source);
            $sy=imagesy($source);
         }
In function ocf_member_choose_avatar of sources/ocf_members_action2.php .
  ;)
Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#87178
Chris Graham
Avatar

ocStaff (admin)
Wow, well done :). I was literally just going to take a look after reviewing exactly what GD was doing. I had assumed that GD was getting the "Logical Screen Descriptor" dimensions, and that we'd need to do a deeper parse to get it all – but you're right, it was getting it for the first frame, and the "Logical Screen Descriptor" is actually easy to get and guaranteed to fit any frame within it.


Become a fan of ocPortal on Facebook or add me as a friend.

Expand: Was I helpful? Was I helpful?

Expand: Follow me on Twitter Follow me on Twitter







If I answered something that you think should be in the documentation, please take the initiative and add it to the community documentation. We really need people to help out here and build a well-organised large support resource.
Back to the top
 
Important!
Posted
Item has a rating of 5 (Liked by Jean)  
Rating:
#87179
Chris Graham
Avatar

ocStaff (admin)

Automated fix message

temp1024 said

Or, option 3 would be to change:

Code

         $sx=imagesx($source);
         $sy=imagesy($source);
to:

Code

         if(get_file_extension($avatar_url)=='gif')
         {
            $header = unpack ('@6/'.'vwidth/'.'vheight', $from_file);
            $sx=$header['width'];
            $sy=$header['height'];
         } else
         {
            $sx=imagesx($source);
            $sy=imagesy($source);
         }
In function ocf_member_choose_avatar of sources/ocf_members_action2.php .
  ;)
This issue has been filed on the tracker as issue #621, with a fix.


Become a fan of ocPortal on Facebook or add me as a friend.

Expand: Was I helpful? Was I helpful?

Expand: Follow me on Twitter Follow me on Twitter







If I answered something that you think should be in the documentation, please take the initiative and add it to the community documentation. We really need people to help out here and build a well-organised large support resource.
Important!
 
Posted
Item has a rating of 5 (Liked by Chris GrahamLiked by BobSLiked by Jean)  
Rating:
#87181
temp1024
Avatar

Community saint

Chris Graham said

the "Logical Screen Descriptor" is actually easy to get and guaranteed to fit any frame within it.
Yep, and if you did do a deep inspection of each frame you would find that you couldn't always guarantee to make the numbers work anyway.

For example, if we look at the largest frame in the above animation we get:

Code

154 x 64 <- Largest frame size
 16 x 10 <- corner position in logical screen (i.e. offset)
========
170 x 74 <- Less then the 175 x 75 LSD
Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
1 guests and 0 members have just viewed this: None
Control functions:
 Add topic 
> Forum home » Deploying

Quick reply   Contract

Your name:
Your message:
( First post )