HTML Logo by World Wide Web Consortium (www.w3.org). Click to learn more about our commitment to accessibility and standards.

Moving forward with Composr

ocPortal has been relaunched as Composr CMS, which is now in beta. ocPortal 9 will be superseded by Composr 10.

Head over to compo.sr for our new site, and to our migration roadmap. Existing ocPortal member accounts have been mirrored.


v7.0.1 Bug - Search "More options" ignores some options

Login / Search

 [ Join | More ]
 Add topic 
Posted
Rating:
#87265 (In Topic #17798)
Avatar

Community saint

The main_search block show a "More options" link that contain the limit_to items in the URL, however clicking on the "More options" link takes you to the "Search content" page but not all limited items are show or checked.

If I set my limit_to as (all items available in the drop down list from the helper):
videos
calendar
ocf_posts
images
filedump
comcode_pages
ocf_clubs
polls
news
cedi_pages
ocf_within_topic
ocf_members
catalogue_entries
ocf_own_pt
iotds
cedi_posts
galleries
catalogue_categories
quiz
download_categories
downloads

There are two problems.

1) Of all the options on the "Search content" page, not all are checked. They appear as follows:
Checked items (as expected)

Galleries (galleries)
Images (images)
News (news)
Poll archive (polls)

Unchecked items (but should be checked)

Catalogue categories (catalogue_categories)
Catalogue entries (catalogue_entries)
Forums (ocf_posts)
Members (ocf_members)
Pages (comcode_pages)
Search Private Topics (ocf_own_pt)

No check option (check box is missing)
Posts within topic (ocf_within_topic)

And all the hidden form fields (except for "Posts within topic") have a value="1" implying that they definitely should have been checked.

So this clearly looks like a bug to me.

2) Not all items even appear on the form. The following were missing:
videos
calendar
filedump
ocf_clubs
cedi_pages
iotds
cedi_posts
quiz
download_categories
downloads
I would have expected that all the limit_to items would appear on the form.

I suspect that some of these my have been excluded by design, for example "video" because its a catalogue category.

I won't call this a bug as I don't know the reasoning behind it, but it seems to be inconsistent to exclude most of these items from the form.

Note that I have check this behaviour is still happening in in v8-RC7, the latest test version I have installed.

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Important!
Posted
Rating:
#87274
Avatar

Automated fix message

temp1024 said

The main_search block show a "More options" link that contain the limit_to items in the URL, however clicking on the "More options" link takes you to the "Search content" page but not all limited items are show or checked.

If I set my limit_to as (all items available in the drop down list from the helper):
videos
calendar
ocf_posts
images
filedump
comcode_pages
ocf_clubs
polls
news
cedi_pages
ocf_within_topic
ocf_members
catalogue_entries
ocf_own_pt
iotds
cedi_posts
galleries
catalogue_categories
quiz
download_categories
downloads

There are two problems.

1) Of all the options on the "Search content" page, not all are checked. They appear as follows:
Checked items (as expected)

Galleries (galleries)
Images (images)
News (news)
Poll archive (polls)

Unchecked items (but should be checked)

Catalogue categories (catalogue_categories)
Catalogue entries (catalogue_entries)
Forums (ocf_posts)
Members (ocf_members)
Pages (comcode_pages)
Search Private Topics (ocf_own_pt)

No check option (check box is missing)
Posts within topic (ocf_within_topic)

And all the hidden form fields (except for "Posts within topic") have a value="1" implying that they definitely should have been checked.

So this clearly looks like a bug to me.

2) Not all items even appear on the form. The following were missing:
videos
calendar
filedump
ocf_clubs
cedi_pages
iotds
cedi_posts
quiz
download_categories
downloads
I would have expected that all the limit_to items would appear on the form.

I suspect that some of these my have been excluded by design, for example "video" because its a catalogue category.

I won't call this a bug as I don't know the reasoning behind it, but it seems to be inconsistent to exclude most of these items from the form.

Note that I have check this behaviour is still happening in in v8-RC7, the latest test version I have installed.
This issue has been filed on the tracker as issue #629, with a fix.


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Important!
 
Posted
Rating:
#87275
Avatar

You'll probably find the git diff most helpful:

https://github.com/chrisgraham/ocPortal/commit/445f45a

Some items are not shown on the form, because the form is filtered for what content currently exists. The block construction assistant isn't as it has a potential view to the future content rather than the current content.


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#87285
Avatar

Community saint

Much better, thanks Chris.

The only issue that remains then is the extra items that are checked. For example when I limit to calendar & ocf_posts, the Galleries, Images, News & Poll archives are also checked. I know those last 4 items are probably the default, but they should not be checked if I am limiting.

Chris Graham said

You'll probably find the git diff most helpful:
Ah yes, thought the missing "search_" prefix was significant.
Some items are not shown on the form, because the form is filtered for what content currently exists.
Thought it might have been something like that, but I was thinking more in terms of which modules were enabled rather then which actually contained data.
The block construction assistant isn't as it has a potential view to the future content rather than the current content.
Makes sense.



Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#87300
Avatar

Tracker topic updated.


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#87304
Avatar

Community saint

Almost there.

I get a "This search type is not available" error if I don't always include catalogue_catagories, even if all I want is just ocf_posts.

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Important!
Posted
Rating:
#87306
Avatar

Automated fix message

temp1024 said

Almost there.

I get a "This search type is not available" error if I don't always include catalogue_catagories, even if all I want is just ocf_posts.
This issue has been filed on the tracker in issue #629, with a fix.


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Important!
 
Posted
Rating:
#87323
Avatar

Community saint

Chris Graham said

You'll probably find the git diff most helpful:

https://github.com/chrisgraham/ocPortal/commit/445f45a

Some items are not shown on the form, because the form is filtered for what content currently exists. The block construction assistant isn't as it has a potential view to the future content rather than the current content.
Fixed, thanks Chris :thumbs: .

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
1 guests and 0 members have just viewed this: None
Control functions:

Quick reply   Contract

Your name:
Your message: