HTML Logo by World Wide Web Consortium (www.w3.org). Click to learn more about our commitment to accessibility and standards.

Moving forward with Composr

ocPortal has been relaunched as Composr CMS, which is now in beta. ocPortal 9 will be superseded by Composr 10.

Head over to compo.sr for our new site, and to our migration roadmap. Existing ocPortal member accounts have been mirrored.


[RESOLVED] v6.1 - maintain_theme_in_link is not defined

Login / Search

 [ Join | More ]
 Add topic 
Posted
Rating:
#68442 (In Topic #14542)
Avatar

Community saint

Getting "maintain_theme_in_link is not defined" errors everywhere.


Last edit: by temp1024

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#68448
Avatar

Community saint

Actually, that specific problem was caused by templates_custom/JAVASCRIPT.tpl not being updated as I did not run the automatic theme upgrader (I have made too many changes to my theme to let the auto upgrader mess with it)

I have since upgraded to the new JAVASCRIPT.tpl, but now get the following javascript error:

    Error: selected_start.inArray is not a function
    Source File: …/themes/mytheme/templates_cached/EN/javascript_tree_list.js
    Line: 116

when I use the "Search underneath" tree on the "Search – Posts" page.

(and while your are working with the tree list, you might want to take a look at the fact that the default selection in the tree is shown as "The current selection is ‘-1’.")

I've also made changes to the following templates:

    templates_custom/HEADER.tpl
    templates_custom/OCF_MEMBER_DIRECTORY_SCREEN.tpl
    templates_custom/BLOCK_MAIN_POLL_IFRAME.tpl
    templates_custom/BLOCK_SIDE_SHOUTBOX_IFRAME.tpl
    templates_custom/IFRAME_SCREEN.tpl

Have any of these changed from v6.0.3 to 6.1 such that I should re-build them using the new templates?

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#68462
Avatar

Always best to keep out of the JAVASCRIPT*.tpl templates for this kind of reason.

I'm adding a note to it "Ideally this template should not be edited. See the note at the bottom of how JAVASCRIPT_CUSTOM_GLOBALS.tpl is appended to this template".

Javascript functions are just variables (it's a very weird language in some ways, but really also very clever). If you redefine them in JAVASCRIPT_CUSTOM_GLOBALS.tpl it should take precedence.

The 'inArray' is due to JAVASCRIPT_MORE.tpl again I believe (see your OcCLE topic).

BLOCK_*_IFRAME.tpl have had &utheme={$THEME*&} added in. It won't break to not have it, but the themeing will always be the site zone's if you don't (or some similar issue).

Looking at tree list issue now.


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#68466
Avatar

Community saint

Chris Graham said

Always best to keep out of the JAVASCRIPT*.tpl templates for this kind of reason.
I see that now. I was actually about to modify JAVASCRIPT_TREE_LIST.tpl before v6.1 was released. Need to modify the hard coded colours in tree_list.prototype.render_tree and tree_list.prototype.make_element_look_selected.

Looks like I'll still have to modify JAVASCRIPT_TREE_LIST.tpl as there does not appear to be an override for it.

Chris Graham said

I'm adding a note to it "Ideally this template should not be edited. See the note at the bottom of how JAVASCRIPT_CUSTOM_GLOBALS.tpl is appended to this template".
That's good. Because changes get put in the custom directory, I just treated it that same way as themes and other templates. I'm sure I'm not alone!

Chris Graham said

Javascript functions are just variables (it's a very weird language in some ways, but really also very clever). If you redefine them in JAVASCRIPT_CUSTOM_GLOBALS.tpl it should take precedence.
Yeh, I know.  I've done some crazy things in javascript in my time.

Chris Graham said

BLOCK_*_IFRAME.tpl have had &utheme={$THEME*&} added in. It won't break to not have it, but the themeing will always be the site zone's if you don't (or some similar issue).
And there are changes to the iframe names/ID's. And given that I raised the themeing issue  a while ago, I'd better merge my allowTransparency="true" changes into the new templates.

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#68467
Avatar

Looks like I'll still have to modify JAVASCRIPT_TREE_LIST.tpl as there does not appear to be an override for it.

No ideal solution here, but the file is less interconnected and volatile. If we change it it is probably only a direct fix to that file.

And there are changes to the iframe names/ID's

That is a fix to a very minor issue. Copy the change if you like, but you don't need it.


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#68471
Avatar

Community saint

Chris Graham said

Copy the change if you like, but you don't need it.
I'll copy it across for completeness.

Chris Graham said

The 'inArray' is due to JAVASCRIPT_MORE.tpl again I believe (see your OcCLE topic).
Indeed it was, and it is now fixed.

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
1 guests and 0 members have just viewed this: None
Control functions:

Quick reply   Contract

Your name:
Your message: