HTML Logo by World Wide Web Consortium (www.w3.org). Click to learn more about our commitment to accessibility and standards.

Moving forward with Composr

ocPortal has been relaunched as Composr CMS, which is now in beta. ocPortal 9 will be superseded by Composr 10.

Head over to compo.sr for our new site, and to our migration roadmap. Existing ocPortal member accounts have been mirrored.


[RESOLVED] Gallery navigation buttons do not honour themes

Login / Search

 [ Join | More ]
 Add topic 
Posted
Rating:
#69829 (In Topic #14802)
Avatar

Community saint

The navigation buttons in the gallery (previous, next, slide-show), do not honour the current theme.


Last edit: by temp1024

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#69834
Avatar

I don't think that can be the case. I wonder if you're uploading manually but there's already a theme image under themes/themename/images_custom/EN/page/previous.png (under 'EN' because it is a translated one - contains text).
The theme image presence is also cached (doesn't search the filesystem on each page load), which can be emptied via the cleanup tools. And you can use manage theme images feature under themes to see exactly what path it is currently mapped to.


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#69835
Avatar

Community saint

All images were uploaded in bulk via FTP, and this is the only sub-set of images that is not behaving as expected. The image being displayed are from /default/images/EN/page/.

I have done many full cache flushes since loading these images as I have been playing with templates.

The theme manager shows the correct image.

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#69873
Avatar

Ah, this is an unfortunate regression caused by our changes to how e-mails are sent out. Theme images are getting called up by what theme the template is in, so because GALLERY_NAV.tpl is not overridden, it calls the 'default' theme.

This will fix it…

Attachment
sources/tempcode_compiler.php
» Download: tempcode_compiler.php (27 Kb, 114 downloads so far)


The Template cache needs emptying.


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#69876
Avatar

Community saint

That's much better!

While were on the subject of emails, you might want to check theme honouring there as well. It 'almost' seems like hit and miss as to which email will get full custom theme, and which will get a mix of custom theme and default theme. Most of emails seem to have the custom theme (even if the background image/background colour is missing), but here are two examples that don't:





The first is an error message that has custom theme colours (missing background image or background colour, don't know if this is a hotmail specific issue) , but the logo image is from the default theme.

The second is an activation email. Same problems as above, but in gmail. Also not the bucket-load of attached images (65!),  yet there is only one image in the body of the mail.

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#69887
Jon

Non-joined user

Thank you Temp1024 for bringing to attention and Chris for fixing - I was experiencing the same issue after I had upgraded to 7.x . All fixed now though so thanks. :cool:
Back to the top
 
Posted
Rating:
#69894
Avatar

Community saint

No problems Jon. I've raised a few theme honouring issues. Hopefully these will be the last  ;) .

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#69913
Avatar

I think the logo issue is the same as in this topic. The large number of issues may be a validation issue in your CSS, one too many '}'. The attached will make our CSS-filterer more tolerant.
Attachment
sources/mail.php
» Download: mail.php (32 Kb, 110 downloads so far)


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#69915
Avatar

Community saint

That looks to be the case, I have one extra '}' somewhere. Will investigate further tomorrow.

Thanks!

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#69951
Avatar

Community saint

I had a missing "{" after a long list of selectors. I put it back and no longer get all those extra attachments.

I'm now also using the updated mail.php (after I verified the source of the problem) to have that extra bit of protection.

The logo issue looks like it's fixed also.

Thanks Chris!

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
There are too many online users to list.
Control functions:

Quick reply   Contract

Your name:
Your message: