HTML Logo by World Wide Web Consortium (www.w3.org). Click to learn more about our commitment to accessibility and standards.

Moving forward with Composr

ocPortal has been relaunched as Composr CMS, which is now in beta. ocPortal 9 will be superseded by Composr 10.

Head over to compo.sr for our new site, and to our migration roadmap. Existing ocPortal member accounts have been mirrored.


Repeating email text

Login / Search

 [ Join | More ]
 Add topic 
Posted
Rating:
#103350 (In Topic #20233)
Avatar

Well-settled

When a user recommends my site to more that one person, the 2nd person will get the email with the body of text 2 times. The 3rd person will get the body of the text 3 times, and so on....

What could be the problem  :(

Robert W
Back to the top
 
Posted
Item has a rating of 5 (Liked by Fletch)  
Rating:
#103351
Avatar

Community saint

I can confirm this. I don't have a tested fix for it, but I think I can narrow it down for Chris.

Looks like a bug with line 635 of pages/modules/recommend.php:

Code

$message=do_lang((post_param_integer('invite',0)==1)?'INVITE_MEMBER_MESSAGE':'RECOMMEND_MEMBER_MESSAGE',$name,$url,array(get_site_name(),$join_url)).$message;

Each time it cycles through the foreach loop (once for each email address to send to), the $message keeps appending to itself.

A possible fix, with the least number of changes, would be to add a $_message=$message; line above the foreach loop, and then change the second $message in the code box above to $_message.
Back to the top
 
Posted
Rating:
#103355
Avatar

Thanks Jason :).


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Important!
Posted
Rating:
#103356
Avatar

Automated fix message

Robert W said

When a user recommends my site to more that one person, the 2nd person will get the email with the body of text 2 times. The 3rd person will get the body of the text 3 times, and so on....

What could be the problem  :(

Robert W
This issue has been filed on the tracker as issue #1638, with a fix.


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Important!
 
Posted
Item has a rating of 5 (Liked by Fletch)  
Rating:
#103362
Avatar

Well-settled

Thank you both Jason & Chris for so quick a fix of this problem. :thumbs:

To anyone that is new to ocPortal. This should give you reassurance that whatever bugs you may find, they are quick to fix them.

Do not give up on ocPortal; it does have a bit of a learning curve. But once you get the hang of it you will find it hard to give up.
 
Robert W.
Back to the top
 
There are too many online users to list.
Control functions:

Quick reply   Contract

Your name:
Your message: