HTML Logo by World Wide Web Consortium (www.w3.org). Click to learn more about our commitment to accessibility and standards.

Moving forward with Composr

ocPortal has been relaunched as Composr CMS, which is now in beta. ocPortal 9 will be superseded by Composr 10.

Head over to compo.sr for our new site, and to our migration roadmap. Existing ocPortal member accounts have been mirrored.


[RESOLVED] v7.0.1 - Unable to delete signature

Login / Search

 [ Join | More ]
 Add topic 
Posted
Rating:
#88358 (In Topic #17911)
Avatar

Community saint

I have a signature which I want to delete by clearing the text of the signature, but I get a "Please check back over the form - you did not fill in all fields on the form correctly" error and the field turns red.

I tried this in both the simple form editor and the WYSIWYG editor.


Last edit: by temp1024

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#88359
Avatar

Yes I can see this, affects v7, not v8+, fix is…

In personalzone/pages/modules/editsignature.php

Code

$posting_form=get_posting_form(do_lang('SAVE'),$_signature_original,$post_url,new ocp_tempcode(),new ocp_tempcode(),do_lang('SIGNATURE'),'',NULL,$_signature,$javascript);
to

Code

$posting_form=get_posting_form(do_lang('SAVE'),$_signature_original,$post_url,new ocp_tempcode(),new ocp_tempcode(),do_lang('SIGNATURE'),'',NULL,$_signature,$javascript,NULL,false);


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#88360
Avatar

Community saint

No Joy :( .

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#88361
Avatar

Did it get rid of a JS error and leave a server-side error?

I think:

Code

$signature=post_param('post');
also needs to be:

Code

$signature=post_param('post','');

I don't currently have a v7 install to test on.


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#88364
Avatar

Community saint

No change. JS error is still there.

Actually, I'm wondering if it might be client-side and not server side at all. Its returning almost instantly, which I assume is just because of a fast ajax response given that the signature was empty.

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
Posted
Rating:
#88378
Avatar

Ah. I just tested, and my fix worked… on v7.1.6.

I then realised you weren't on that and looked, and the forms API doesn't support non-required posting forms on v7.0.1.

I think this workaround would work. POSTING_FORM.tpl…

Code

                        <textarea accesskey="x" class="{CLASS*} posting_required wide_field" tabindex="{TABINDEX_PF*}" id="post" name="post" cols="70" rows="17">{POST*}</textarea>
–>

Code

                        <textarea accesskey="x" class="{CLASS*}{+START,IF,{$NOT,{$MATCH_KEY_MATCH,personalzone:editsignature}}} posting_required{+END} wide_field" tabindex="{TABINDEX_PF*}" id="post" name="post" cols="70" rows="17">{POST*}</textarea>


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#88406
Avatar

Community saint

Chris Graham said

Ah. I just tested, and my fix worked… on v7.1.6.
Ah. I just tested, and your TPL fix worked… on v7.0.1.

 :thumbs:

Do you have a Samsung Galaxy S / Galaxy S II ? If so, why not check out my ScreenFree FM Radio .
Back to the top
 
There are too many online users to list.
Control functions:

Quick reply   Contract

Your name:
Your message: