HTML Logo by World Wide Web Consortium (www.w3.org). Click to learn more about our commitment to accessibility and standards.

Moving forward with Composr

ocPortal has been relaunched as Composr CMS, which is now in beta. ocPortal 9 will be superseded by Composr 10.

Head over to compo.sr for our new site, and to our migration roadmap. Existing ocPortal member accounts have been mirrored.


[CLOSED] - <8.0.1 - minor gripe

Login / Search

 [ Join | More ]
 Add topic 
Posted
Rating:
#84944 (In Topic #17493)
Avatar

Community saint

For several v.8 upgrades the upgrader tool refuses to recognise a genuine 'edited' file in the sources_custom folder.

The facts:
  • file in question is sources/misc_scripts
  • the standard downloaded file has these lines


   $trans_color=array_key_exists('color',$_GET)?$_
GET['color']:'FF00FF';
   $img=imagecreatetruecolor($width,$height+$basel
ine_offset);
   imagealphablending($img,false);
   $black_color=array_key_exists('fgcolor',$_GET)?
$_GET['fgcolor']:'000000';


  • my changes (below) are saved in sources_custom/misc_scripts
  • the upgrader refuses to accept the convention and reports it as an outdated file


   $trans_color=array_key_exists('color',$_GET)?$_
GET['color']:'FFFFFF';
   $img=imagecreatetruecolor($width,$height+$basel
ine_offset);
   imagealphablending($img,false);
   $black_color=array_key_exists('fgcolor',$_GET)?
$_GET['fgcolor']:'33CCCC';


I class it as 'minor' and a 'gripe' because the upgrader does advise that 'edited' files should be ignored when reported. However, that appears to be inconsistent behaviour, especially when it happily overlooks OTHER edited files in OTHER '_custom' folders.

Thoughts?

 :thumbs:


Last edit: by Fletch

Take my advice. I'm not using it!

View my working ocPortal site (version 9.x.x) at Anglo-Indian Portal
Back to the top
 
Posted
Rating:
#84945
Avatar

Code files can be a bit more catastrophic as far as upgrades go. CSS, Comcode pages, etc - that's just layout. But PHP overrides could make it explode.

However, no need to run the integrity check at all for a patch upgrade. It's only really useful when there are substantial reworkings going on in the new version.

p.s. Nice to see you editing PHP, even if it is a simple change :).


Become a fan of ocPortal on Facebook or add me as a friend. Add me on on Twitter.
Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about ocPortal whenever you see the opportunity.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying ocPortal on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Back to the top
 
Posted
Rating:
#84946
Avatar

Community saint

Nice to see you editing PHP, even if it is a simple change :).

HAH!

I've actually edited various other PHP AND TPL files, but I don't claim to be in my comfort zone when doing it. I check each 'edit' immediately after the change; if it works, it stays. If it screws up (and sometimes they screw up big time!), I immediately restore the edit.

Common sense, I guess, but the tacit encouragement goes a long way!

 :thumbs:

Take my advice. I'm not using it!

View my working ocPortal site (version 9.x.x) at Anglo-Indian Portal
Back to the top
 
1 guests and 0 members have just viewed this: None
Control functions:

Quick reply   Contract

Your name:
Your message: